Run on RPTU servers #1062
Run on RPTU servers #1062
Conversation
I am not sure if this is actually correct.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1062 +/- ##
=======================================
Coverage 74.97% 74.97%
=======================================
Files 55 55
Lines 4560 4560
=======================================
Hits 3419 3419
Misses 1141 1141 |
|
This currently spawns two values for runs-on: Linux, and RPTU. What we really want is one runs-on, with two labels: Linux and RPTU (such that github then forwards this job to only runners tagged with both of these labels). Only forwarding it to RPTU tagged runners means it might get run on one of the macos runners, and only forwarding it to Linux tagged runners leaves it open to running on other runners (in case github ever labels their runners as linux in addition to ubuntu). Documentation for choosing a runner using labels : https://docs.github.com/en/actions/writing-workflows/choosing-where-your-workflow-runs/choosing-the-runner-for-a-job#targeting-runners-in-a-group cc @benlorenz @fingolfin any ideas ? |
There was a problem hiding this comment.
The outer array will be used expanded for the matrix job, so we need one more level of arrays, then this should work. Except that the job-name will not be generated properly and print Array as OS name. But this name-generation needs a rework anyway...
Edit: The matrix context for the generated sub-jobs now has both labels in os:
{
"branches": {
"name": "matching: [Oscar#master]",
"branch": "ak96/rptu-local-runners",
"pkgs": {
"Oscar": {
"options": [],
"test": true,
"branch": "master"
}
}
},
"julia-version": "~1.10.0-0",
"os": [
"Linux",
"RPTU"
]
}https://github.com/oscar-system/GAP.jl/actions/runs/11575068230/job/32220834450?pr=1062#step:6:50
I am not sure if this is actually correct, more explanation on why, if this doesn't work.